Add post install notes #163
Conversation
| if post_install_notes: | ||
| # Let's use errors.DefaultError for now because that is currently the | ||
| # only way to print messages to stderr | ||
| emitter.publish(errors.DefaultError(post_install_notes)) |
There was a problem hiding this comment.
why should we print this to stderr?
There was a problem hiding this comment.
We need to work on documentation. postInstallNotes is in the universe example, but we don't actually document these properties anywhere.
There was a problem hiding this comment.
why should we print this to stderr?
Done.
There was a problem hiding this comment.
We need to work on documentation. postInstallNotes is in the universe example, but we don't actually document these properties anywhere.
Yes. We have a lot of information in different places but we do need to improve our user experience.
jsancio
force-pushed
the
dcos-611-post-install
branch
from
70ee225
to
94ee97b
Compare
| @@ -594,7 +595,10 @@ def _install_mesos_dns( | |||
| args=['--options=tests/data/package/mesos-dns-config.json'], | |||
| returncode=0, | |||
| stdout=b'Installing package [mesos-dns] version [alpha]\n', | |||
| stderr=b''): | |||
| stderr=b'', | |||
| postInstallNotes=b'Please refer to the tutorial instructions for ' | |||
There was a problem hiding this comment.
why not just append this to stdout?
There was a problem hiding this comment.
We overwrite the stdout parameter in a few places. I didn't want to copy that string everywhere. See: https://github.com/mesosphere/dcos-cli/blob/dcos-611-post-install/cli/tests/integrations/cli/test_package.py#L335
No description provided.