Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Initial draft for adding a quickstart for Joomla #6255

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rpkoller
Copy link
Collaborator

The Issue

Initial draft for adding a quickstart for joomla to https://ddev.readthedocs.io/en/latest/users/quickstart/ . Only downside unfortunately i havent found a static link for download the latest archive with curl.

How This PR Solves The Issue

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rpkoller rpkoller requested a review from a team as a code owner May 29, 2024 12:04
@rpkoller rpkoller requested a review from a team as a code owner May 29, 2024 13:03
@rpkoller
Copy link
Collaborator Author

@carcam one question, does joomla have some sort of default upload directory? cuz while testing the latest iteration of the quickstart i've noticed:

You have Mutagen enabled and your 'php' project type doesn't have `upload_dirs` set.
For faster startup and less disk usage, set upload_dirs to where your user-generated files are stored.
If this is intended you can disable this warning with `ddev config --disable-upload-dirs-warning`.

must have overlooked those on previous projects.

@rfay
Copy link
Member

rfay commented May 31, 2024

If there is not a default place for uploads/user-generated files, we can either leave this to pester the user to get it set where it belongs, or we can add --disable-upload-dirs-warning

@rpkoller
Copy link
Collaborator Author

did some quick research and it looks per default everything is uploaded into ./images

@rpkoller rpkoller force-pushed the 20240529-rpkoller-joomla-quickstart branch from 004e0e5 to ff7a6f0 Compare June 1, 2024 00:10
@carcam
Copy link

carcam commented Jun 3, 2024

@rpkoller your research is right. The images folder at the root of Joomla is the common folder to place images for your content and it's kind of the place some extension developers storage user uploaded data when it's public.

Another interesting folder could be the media folder. Where extensions usually upload their public assets and finally a good one could be: templates/**/html/. Not sure if the upload_dirs support glob though...

@rpkoller
Copy link
Collaborator Author

rpkoller commented Jun 3, 2024

i've quickly chatted with randy. wildcards dont work in this context here unfortunately. but out of curiosity, i knew it was possible to set more than one upload directory but was uncertain about the actual syntax. turns out all of the following works:

ddev config --project-type=php --webserver-type=apache-fpm --upload-dirs=images,templates/test
ddev config --project-type=php --webserver-type=apache-fpm --upload-dirs="images","templates/test"
ddev config --project-type=php --webserver-type=apache-fpm --upload-dirs='"images","templates/test"'

but in regards of the joomla quickstart guide i would vote to stick to only set the upload directory to the images directory?

@carcam
Copy link

carcam commented Jun 4, 2024

@rpkoller simplicity is a plus when aiming quickstarts, so I see it ok.

@rpkoller rpkoller force-pushed the 20240529-rpkoller-joomla-quickstart branch from ff7a6f0 to 3f0072d Compare June 13, 2024 22:05
@rfay
Copy link
Member

rfay commented Jun 13, 2024

Thanks for your work on this. It will get in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants