Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Warn about Codespaces #6321

Merged
merged 3 commits into from
Jun 21, 2024
Merged

docs: Warn about Codespaces #6321

merged 3 commits into from
Jun 21, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Jun 17, 2024

The Issue

We haven't had consistent success with Codespaces.

The discussion in Discord indicated not to remove it but rather to warn a bit.

@rfay rfay marked this pull request as ready for review June 17, 2024 18:36
@rfay rfay requested review from a team as code owners June 17, 2024 18:36
@mandrasch
Copy link
Collaborator

mandrasch commented Jun 18, 2024

Hey @rfay, thanks for mentioning my-ddev-lab.mandrasch.eu 👍

@rfay
Copy link
Member Author

rfay commented Jun 18, 2024

Thanks @mandrasch - Is this OK at this point though, good enough to say what's happening right now?

@mandrasch
Copy link
Collaborator

@rfay I added a suggestion

  • I removed "It seems to change without warning" since this was a one-time thing with the codespaces official URL change, at least this is my current state of knowledge
  • I linked to the recent issue with postCreateCommand - this is the best way to guide users imho :)

good to have a warning in the docs 👍

Co-authored-by: Matthias Andrasch <777278+mandrasch@users.noreply.github.com>
@rfay rfay merged commit 2dbe1d6 into ddev:master Jun 21, 2024
10 checks passed
@rfay rfay deleted the 20240617_codespaces branch June 21, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants