Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runtime dependency on base64 #618

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Remove runtime dependency on base64 #618

merged 1 commit into from
Jan 15, 2024

Conversation

Earlopain
Copy link
Contributor

Ruby 3.3 prints a warning if base64 is used without specifying it in the gemfile. Ruby 3.4 will error.
Since it's just a wrapper around the pack/unpack methods it's trivial to replace.

You don't see this in CI since the Gemfile contains dependencies that in turn already depend on base64, like activesupport.

Here is some similar work:

Ruby 3.3 prints a warning if base64 is used without specifying it in the gemfile.
Ruby 3.4 will error
@ddnexus ddnexus changed the base branch from master to dev January 15, 2024 14:05
@ddnexus ddnexus merged commit 2e60cac into ddnexus:dev Jan 15, 2024
6 checks passed
@ddnexus
Copy link
Owner

ddnexus commented Jan 15, 2024

Thank you!

@Earlopain Earlopain deleted the remove-base64-dep branch January 15, 2024 14:17
@Earlopain
Copy link
Contributor Author

New release already, very cool!

ddnexus pushed a commit that referenced this pull request Jan 19, 2024
Ruby 3.3 prints a warning if base64 is used without specifying it in the gemfile.
Ruby 3.4 will error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants