Fix DocSearch link alignment #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit 941a58f |
|
Deploy preview for cms-demo ready! Built with commit 941a58f |
|
@verythorough Great talk at Fosdem yesterday by the way. You're really fast at deploying the previews! 😅 |
|
@pixelastic Can you add yourself to the contributors list: https://github.com/netlify/netlify-cms/blob/master/CONTRIBUTING.md#add-yourself-as-a-contributor You can just push it to this PR if you want. |
|
Done! ✅ |
tech4him1
approved these changes
Feb 5, 2018
|
@pixelastic p.s.: @verythorough isn't ignoring you, those deploy preview messages were generated by a bot she created :) |
|
lol, @pixelastic Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
The current live documentation website of Netlify CMS displays a scrollbar in the search dropdown menu:
This is due to the "Search by Algolia" link being slightly too offset on the right. This PR solves this by making the offset only apply to top-level links in the header, and not all links in the dropdown.
- Test plan
This is the new output after the slight change of markup. The content of the dropdown is correctly styled, while the top-level links keep their initial styling.
- Description for the changelog
Only applied link styling in the header to the top-level links.
- A picture of a cute animal (not mandatory but encouraged)