Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: change unpkg links to pull latest release #455

Merged
merged 2 commits into from
Jun 24, 2017

Conversation

verythorough
Copy link
Contributor

@verythorough verythorough commented Jun 15, 2017

- Summary
html snippets in the docs demonstrate loading the CMS via an unpkg.com link that's pinned at v0.3 (or 0.x in a few places). This changes the link to point to the latest release instead.

- Test plan
None

- Description for the changelog
Docs: update links to unpkg.com to pull the latest release of Netlify CMS.

- A picture of a cute animal (not mandatory but encouraged)
http://i.imgur.com/rDiVe2z.gifv (technically not an image, but too cute)

@verythorough
Copy link
Contributor Author

verythorough commented Jun 16, 2017

After discussion, it seemed to make more sense to pin to the minor version than to pull latest. Note that we'll need to update this whenever there's a minor version release (or set up a method like Webpack's DefinePlugin to handle it).

Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdougie
Copy link
Contributor

bdougie commented Jun 23, 2017

FYI, my serverless docs deploy hook is broken. I am going to look into it tomorrow morning, this got busy :)

Copy link
Contributor

@Benaiah Benaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdougie
Copy link
Contributor

bdougie commented Jun 24, 2017

@verythorough and @erquhart I am happy to say, the cms docs webhook works now. So as soon as this is merged it should trigger a deploy to the cms-www go live without another step. I am going do a blog post about this severless setup soon.

https://github.com/netlify/netlify-cms-docs-webhook

The webhook is hosted on my AWS account for now, I will ask about getting this on the Netlify creds on Monday, but for now, try to stay under 1 million merges this month :)

@Benaiah Benaiah merged commit 37cce53 into master Jun 24, 2017
@bdougie
Copy link
Contributor

bdougie commented Jun 24, 2017

I stand corrected, I got another error, but I will fix

@verythorough verythorough deleted the docs-update-unpkg-links branch June 24, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants