Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListControl collapsing bug #738

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Conversation

Benaiah
Copy link
Contributor

@Benaiah Benaiah commented Oct 25, 2017

- Summary

ListControl would not actually hide its ObjectControls when they were collapsed. This was a simple CSS precedence issue.

- Test plan

Tested manually, problem is resolved.

- Description for the changelog

Fix ListControl collapsing bug

Copy link
Contributor

@tech4him1 tech4him1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Benaiah Benaiah merged commit b501db7 into master Oct 25, 2017
@Benaiah Benaiah deleted the fix-list-control-collapsing-bug branch October 25, 2017 23:29
talves pushed a commit that referenced this pull request Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants