update chi for fixes to SIV snafu and a data race #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
changed the title
buck54321
approved these changes
Mar 29, 2021
|
Oh. Just realized this is still in draft. Any reason to hold it up? |
|
Haven't tested it myself is all. |
This updates to chi/v5, which is the same as v1.5.4, just with proper semantic import versioning (SIV). The project conceded the 1.5.x approach did not work out since latest was previously v4. This also pulls in a chi data race fix in v1.5.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to chi/v5, which is the same as v1.5.4, just with proper
semantic import versioning (SIV). The project conceded the 1.5.x
approach did not work out since latest was previously v4.
See go-chi/chi#561 for an epic discussion of this saga.
This also pulls in a chi data race fix in v1.5.2.