tests: add tests for scalarMult and parsePubKey in crypto.secp256k1.curve.KoblitzCurve #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teknico
commented
Feb 14, 2020
| @@ -260,8 +270,10 @@ def scalarMult(self, Bx, By, k): | |||
| # elliptic curves states that P(x, y) = -P(x, -y), it's faster and | |||
| # simplifies the code to just make the point negative. | |||
| if k1 < 0: | |||
| k1 = -k1 | |||
There was a problem hiding this comment.
In Go, KoblitzCurve.splitK always returns absolute k1 and k2, and their signs are returned separately. Here, KoblitzCurve.splitK returns signed k1 and k2. When they are negative they cannot be converted to ByteArrays on lines 283-284 below. Their negative sign is handled explicitly here, so they can be turned into absolute values safely.
teknico
commented
Feb 14, 2020
| p1y, p1yNeg = p1yNeg, p1y | ||
| if k2 < 1: | ||
| if k2 < 0: |
There was a problem hiding this comment.
Same test as for k1 above, clearly a typo.
buck54321
approved these changes
Feb 14, 2020
- test helpers "randBytes" and "sign" removed from util/helpers.py and moved to a conftest.py file in the tests/ root directory, as pytest fixtures; - test_curve.py changed to use the new fixtures; - unit/util/test_database.py restored to its original state.
- fixed two bugs in KoblitzCurve.scalarMult; - renamed curve.curve in test_curve.py; - edited several docstrings in curve.py .
- implement PublicKey.__eq__; - use ValueError instead of Exception in KoblitzCurve.parsePubKey .
buck54321
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #70, based on #74.
Add tests for
KoblitzCurve.scalarMultandKoblitzCurve.parsePubKeyindecred/crypto/secp256k1/curve.py.KoblitzCurve.scalarMult:curve.curvetocurve_objintest_curve.py.KoblitzCurve.parsePubKey:PublicKey.__eq__;