Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethinking the iCloud sign-in flow #42

Merged
merged 3 commits into from
Dec 3, 2023
Merged

Rethinking the iCloud sign-in flow #42

merged 3 commits into from
Dec 3, 2023

Conversation

dedoussis
Copy link
Owner

@dedoussis dedoussis commented Nov 27, 2023

Instead of signing-in through the pop-up, the extension will prompt the user to sign-in through https://icloud.com. The background script will sniff the responses of the icloud.com requests (via webRequest listeners) to extract the auth tokens it needs.

Signing-in through the official icloud.com page of Apple has the following benefits:

  1. Support for security key 2FA (alongside the 6 digit code one). Fixes add support for hardware key (2fa) login #41 and maybe Support for Advanced Data Protection Hardware keys #26
  2. Support for Passkeys (alongside passwords)
  3. Feels more secure from a user pov. Even though there's no practical difference, users feel more comfortable submitting their password on an Apple hosted surface rather than a random extension.

TODOs to get the extension into a publishable state:

  • Add post installation help page
  • Test 6 digit code 2FA
  • Test passkey sign-in
  • Test on Firefox
  • Fix dependabot alerts
  • Stretch: rework the SignInInstructions copies/presentation

dedoussis and others added 2 commits December 2, 2023 11:37
Co-authored-by: Daniel Rocha <daniel@rocha.io>
@dedoussis dedoussis merged commit 33e0246 into main Dec 3, 2023
2 checks passed
@dedoussis dedoussis deleted the revamp-sign-in branch December 3, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for hardware key (2fa) login
2 participants