Remove Helpers.GenerateRandom

It is identical to `RandomNumberGenerator.GetBytes`.
deeprobin · Apr 30, 2022 · a889557 · a889557
1 parent e938e44
commit a889557
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/...ystem.Security.Cryptography/src/System/Security/Cryptography/CngSymmetricAlgorithmCore.cs b/...ystem.Security.Cryptography/src/System/Security/Cryptography/CngSymmetricAlgorithmCore.cs
@@ -86,13 +86,13 @@ public void SetKeySize(int keySize, ICngSymmetricAlgorithm outer)
 
         public void GenerateKey()
         {
-            byte[] key = Helpers.GenerateRandom(AsymmetricAlgorithmHelpers.BitsToBytes(_outer.BaseKeySize));
+            byte[] key = RandomNumberGenerator.GetBytes(AsymmetricAlgorithmHelpers.BitsToBytes(_outer.BaseKeySize));
             SetKey(key);
         }
 
         public void GenerateIV()
         {
-            byte[] iv = Helpers.GenerateRandom(AsymmetricAlgorithmHelpers.BitsToBytes(_outer.BlockSize));
+            byte[] iv = RandomNumberGenerator.GetBytes(AsymmetricAlgorithmHelpers.BitsToBytes(_outer.BlockSize));
             _outer.IV = iv;
         }
 

diff --git a/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/Helpers.cs b/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/Helpers.cs
@@ -61,13 +61,6 @@ public static byte[] FixupKeyParity(this byte[] key)
             return oddParityKey;
         }
 
-        internal static byte[] GenerateRandom(int count)
-        {
-            byte[] buffer = new byte[count];
-            RandomNumberGenerator.Fill(buffer);
-            return buffer;
-        }
-
         // Encode a byte array as an array of upper-case hex characters.
         internal static char[] ToHexArrayUpper(this byte[] bytes)
         {