Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --set option for task runner variables #170

Merged
merged 4 commits into from
Nov 6, 2023
Merged

feat: add --set option for task runner variables #170

merged 4 commits into from
Nov 6, 2023

Conversation

decleaver
Copy link
Collaborator

Description

Addresses #146 adding the --set option to set variables when calling uds run

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

mikevanhemert
mikevanhemert previously approved these changes Nov 6, 2023
View reviewed changes
UncleGedd
UncleGedd reviewed Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@UncleGedd UncleGedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Suggested a couple minor changes

src/config/lang/lang.go Outdated Show resolved Hide resolved
src/cmd/run.go Outdated Show resolved Hide resolved
@decleaver @UncleGedd
Update src/config/lang/lang.go
e80f5f9 
Co-authored-by: UncleGedd <42304551+UncleGedd@users.noreply.github.com>
@decleaver @UncleGedd
Update src/cmd/run.go
0b809d2 
Co-authored-by: UncleGedd <42304551+UncleGedd@users.noreply.github.com>
@UncleGedd UncleGedd self-requested a review November 6, 2023 20:14
UncleGedd
UncleGedd approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@UncleGedd UncleGedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @decleaver !

@decleaver decleaver merged commit 7423bcb into main Nov 6, 2023
7 checks passed
@decleaver decleaver deleted the feat-task-runner--set-var branch November 6, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UncleGedd UncleGedd UncleGedd approved these changes

@mikevanhemert mikevanhemert mikevanhemert left review comments

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@decleaver @UncleGedd @mikevanhemert