-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add uds ui cmd #917
feat: add uds ui cmd #917
Conversation
Can we get around having to add the binaries to the repo? Also we shouldn't need to bundle all versions of Runtime into the binary. For example the darwin-arm64 CLI should embed only the darwin-arm64 Runtime. Thoughts? |
Good point, I can update it to only bundle the matching runtime binary. As far as adding the binaries to the repo, have some thoughts... pros/cons to different approaches. |
Co-authored-by: UncleGedd <42304551+UncleGedd@users.noreply.github.com>
Great work! I explored vendoring for a bit before realizing that was a dead end. One con to the embedding binary approach is that we're creating tmp dirs with the runtime binary on the user's system, and those tmp dirs can potentially be abandoned if the process is killed and the This can be a separate issue, but I'd like to see the following scenarios handled:
|
Created follow on issue: #922 |
Description
Adds
uds ui
which launches uds runtimeRelated Issue
Relates to #870
Type of change
Checklist before merging