Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused GitHub Action install-tools #961

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

catsby
Copy link
Collaborator

@catsby catsby commented Oct 8, 2024

Description

DRAFT: It's not clear to me how these tools are used, or where, or at all. I suspect they are vestigal from scripts/build process borrowed from our friends/ancestor Zarf.

Related Issue

Relates to #445

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: catsby <clint@ctshryock.com>
@catsby catsby requested a review from a team as a code owner October 8, 2024 17:02
Signed-off-by: catsby <clint@ctshryock.com>
Copy link
Collaborator

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noting that all the installs here can be traced to specific things in zarf so likely were just copy/pasted at the start of the project.

@catsby catsby merged commit 656258c into main Oct 8, 2024
17 checks passed
@catsby catsby deleted the purge-install-tools branch October 8, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants