Skip to content

Commit

Permalink
fix: add additional supported saml attributes (#690)
Browse files Browse the repository at this point in the history
## Description
Adds additional supported client attributes

## Related Issue

Fixes #
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
  • Loading branch information
rjferguson21 authored Aug 21, 2024
1 parent 69eb1cb commit a7435bf
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/configuration/uds-operator.md
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ The SSO spec supports a subset of the Keycloak attributes for clients, but does
- oauth2.device.authorization.grant.enabled
- pkce.code.challenge.method
- client.session.idle.timeout
- saml.client.signature
- saml_assertion_consumer_url_post

## Exemption

Expand Down
2 changes: 2 additions & 0 deletions src/pepr/operator/crd/validators/package-validator.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,8 @@ describe("Test Allowed SSO Client Attributes", () => {
"oauth2.device.authorization.grant.enabled": "true",
"pkce.code.challenge.method": "S256",
"client.session.idle.timeout": "3600",
"saml.client.signature": "false",
saml_assertion_consumer_url_post: "https://nexus.uds.dev/saml",
},
},
],
Expand Down
2 changes: 2 additions & 0 deletions src/pepr/operator/crd/validators/package-validator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ export async function validator(req: PeprValidateRequest<UDSPackage>) {
"oauth2.device.authorization.grant.enabled",
"pkce.code.challenge.method",
"client.session.idle.timeout",
"saml.client.signature",
"saml_assertion_consumer_url_post",
]);

for (const client of ssoClients) {
Expand Down

0 comments on commit a7435bf

Please sign in to comment.