fix: fail if ocsp response fails, get ocsp from cert #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjferguson21
approved these changes
Mar 13, 2024
UnicornChance
approved these changes
Mar 14, 2024
mjnagel
changed the title
UnicornChance
approved these changes
Mar 14, 2024
rjferguson21
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches behavior from allowing if OCSP fails to respond to denying. This seems like a sane default, and could be edited easily in the realm/admin console if someone wants to allow on failure.
Also removes the explicit ocsp in favor of the one from the cert.
Related Issue
Related to defenseunicorns/uds-core#255
Type of change
Checklist before merging