-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: zarf file #39
Merged
Merged
feat: zarf file #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noxsios
reviewed
Apr 1, 2024
blancharda
commented
Apr 2, 2024
mjnagel
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues overall with this - seems useful for custom plugin builders. Could you document the new task in the readme + add a small note or two under docs/CUSTOMIZE.md to explain the zarf package piece?
mjnagel
previously approved these changes
Apr 2, 2024
mjnagel
previously approved these changes
Apr 2, 2024
mjnagel
approved these changes
Apr 2, 2024
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Occasionally, it may be useful to transport the identity-config image via zarf package. This PR Adds a simple
zarf.yaml
and corresponding UDS task for building it.This will enable custom builds of this repository image to be more easily incorporated in UDS deployments, particularly in situations where the custom image may not be available at bundle create time.
Type of change