Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zarf file #39

Merged
merged 10 commits into from
Apr 2, 2024
Merged

feat: zarf file #39

merged 10 commits into from
Apr 2, 2024

Conversation

blancharda
Copy link
Contributor

@blancharda blancharda commented Mar 30, 2024

Description

Occasionally, it may be useful to transport the identity-config image via zarf package. This PR Adds a simple zarf.yaml and corresponding UDS task for building it.

This will enable custom builds of this repository image to be more easily incorporated in UDS deployments, particularly in situations where the custom image may not be available at bundle create time.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

zarf.yaml Outdated Show resolved Hide resolved
tasks.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues overall with this - seems useful for custom plugin builders. Could you document the new task in the readme + add a small note or two under docs/CUSTOMIZE.md to explain the zarf package piece?

mjnagel
mjnagel previously approved these changes Apr 2, 2024
mjnagel
mjnagel previously approved these changes Apr 2, 2024
@mjnagel mjnagel merged commit 3cc2ee7 into main Apr 2, 2024
4 checks passed
@blancharda blancharda deleted the feature/zarfify branch April 2, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants