-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: alert users to cluster disconnection and reconnect #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanHoladay
changed the title
feat: alert users to cluster disconnection
feat: alert users to cluster disconnection and reconnect
Sep 6, 2024
TristanHoladay
requested review from
UncleGedd,
jeff-mccoy,
decleaver and
BillyFigueroa
as code owners
September 6, 2024 20:04
UncleGedd
reviewed
Sep 9, 2024
decleaver
reviewed
Sep 9, 2024
decleaver
reviewed
Sep 9, 2024
decleaver
previously approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments addressed and issue being created to look into the timing and number of network calls to /health
decleaver
reviewed
Sep 16, 2024
decleaver
reviewed
Sep 16, 2024
decleaver
reviewed
Sep 16, 2024
decleaver
reviewed
Sep 16, 2024
Co-authored-by: decleaver <85503726+decleaver@users.noreply.github.com>
decleaver
previously approved these changes
Sep 16, 2024
decleaver
previously approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
decleaver
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a cluster connection check endpoint to the backend to poll for cluster connection. Upon cluster disconnection, the frontend will be notified and pop up an alert in the user's view to let them know. The backend will trigger a reconnection handler, which will infinitely retry to connect every 5 seconds until successful or user stops the app. When a new connection is made, the old cache informers will be stopped and a new cache will be created.
To Test
uds run test:k3d
Related Issue
Resolves #10