Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): updates for handling unavailable metrics server #421

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

decleaver
Copy link
Contributor

Description

Backend updates and tests for handling unavailable metrics server.

Sets podmetrics totalCPU and totalMemory to -1 to indicate metrics server is not available which can then be processed in the frontend

Related Issue

@decleaver decleaver marked this pull request as ready for review October 9, 2024 18:57
@TristanHoladay TristanHoladay changed the title chore: (backend) updates for handling unavailable metrics server chore: (api) updates for handling unavailable metrics server Oct 9, 2024
@UncleGedd UncleGedd changed the title chore: (api) updates for handling unavailable metrics server chore(api): updates for handling unavailable metrics server Oct 9, 2024
@UncleGedd
Copy link
Contributor

UncleGedd commented Oct 9, 2024

Small change to make on the Cluster Overview page, note the -0.00 (this was with no metrics server)

Screenshot 2024-10-09 at 3 58 36 PM

@UncleGedd UncleGedd self-requested a review October 9, 2024 23:25
@UncleGedd UncleGedd merged commit 6bb9728 into main Oct 10, 2024
12 checks passed
@UncleGedd UncleGedd deleted the 377-metrics-server-unavailable branch October 10, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants