Minor refactoring

dekelev · Dec 8, 2018 · 4b6cb03 · 4b6cb03
1 parent 24179b2
commit 4b6cb03
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -47,7 +47,7 @@ For example:
         "replacement": "***" // optional. default: '__MASKED__' - The default value to replace
       },
       "hideErrors": { // optional. default: all errors will be tagged with error=true and set with sampling priority 1
-        "users": [404, 409] // optional. tag selected services errors with error=false and don't set their sampling priority to 1. i.e. hide 404 & 409 errors of the `users` service
+        "users": [404, 409] // optional. don't tag selected services errors with error=true and don't set their sampling priority to 1. i.e. hide 404 & 409 errors of the `users` service
       },
       "debug": true  // optional. default: false - Sets sampling priority to 1 to force sampling of all requests
     } 

diff --git a/hooks.js b/hooks.js
@@ -95,9 +95,7 @@ const opentracingError = (options = {}) => {
       span = params.span;
     }
 
-    if (options.hideErrors && options.hideErrors[path] && options.hideErrors[path].includes(code)) {
-      span.setTag(opentracing.Tags.ERROR, false);
-    } else {
+    if (!options.hideErrors || !options.hideErrors[path] || !options.hideErrors[path].includes(code)) {
       span.setTag(opentracing.Tags.SAMPLING_PRIORITY, 1);
       span.setTag(opentracing.Tags.ERROR, true);
     }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "feathers-opentracing",
-  "version": "2.2.3",
+  "version": "2.2.4",
   "description": "OpenTracing integration for FeathersJS services",
   "main": "index.js",
   "repository": {