* Error hook now expects options for handling early unexpected errors

* Updated dependencies and bumped version to 2.1.3
dekelev · Oct 13, 2018 · ba64158 · ba64158
1 parent c308332
commit ba64158
Show file tree

Hide file tree

Showing 4 changed files with 217 additions and 344 deletions.
diff --git a/README.md b/README.md
@@ -123,7 +123,7 @@ module.exports = {
   error: {
     all: [
       ...
-      opentracingError(),
+      opentracingError(config.opentracing.options),
     ]
   },
 };

diff --git a/hooks.js b/hooks.js
@@ -81,14 +81,19 @@ const opentracingEnd = (options = {}) => {
   };
 };
 
-const opentracingError = () => {
+const opentracingError = (options = {}) => {
   return async context => {
     if (context.service.remote)
       return context;
 
-    const { params } = context;
-    const { span } = params;
     const { code, message, stack } = context.error;
+    const { params } = context;
+    let { span } = params;
+
+    if (!span) {
+      opentracingBegin(options)(context);
+      span = params.span;
+    }
 
     span.setTag(opentracing.Tags.SAMPLING_PRIORITY, 1);
     span.setTag(opentracing.Tags.ERROR, true);