Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wip): ADR for implementing checkpoints via recursive SNARKs #91

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

sebasti810
Copy link
Contributor

No description provided.

Copy link

coderabbitai bot commented Jul 22, 2024

Walkthrough

The update introduces an architectural decision record (ADR) for implementing a checkpoint system using recursive SNARKs in the Prism blockchain. This aims to enhance light clients' long-term verifiability and synchronization, addressing limitations posed by Celestia's short block storage duration. The solution is structured into two stages: initially focusing on Groth16 SNARKs in Stage 1, followed by the exploration of advanced systems like Nova or zkVMs in Stage 2, ultimately improving sync times and reducing data requirements.

Changes

Files Change Summary
adr/adr-001-checkpoint-snarks.md Introduced a new ADR detailing the implementation of checkpoint SNARKs using recursive SNARKs, addressing long-term verifiability and synchronization for light clients. The implementation is split into two stages, focusing on Groth16 in Stage 1 and evaluating advanced systems in Stage 2. Risks, implementation details, and alternative solutions are included.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Light Client
    participant CH as Checkpoint SNARK
    participant SN as SNARK System
    participant DB as Block Database

    Client->>CH: Request sync from latest checkpoint
    CH->>SN: Provide checkpoint SNARK
    SN->>DB: Retrieve latest data
    DB-->>SN: Return data
    SN-->>CH: Return SNARK proof
    CH-->>Client: Provide sync data
    Client-->>Client: Complete sync
Loading

Possibly related issues


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Outside diff range, codebase verification and nitpick comments (3)
adr/adr-001-checkpoint-snarks.md (3)

99-99: Add a comma.

A comma might be missing here.

- Test edge cases and boundary conditions
+ Test edge cases and boundary conditions,
Tools
LanguageTool

[uncategorized] ~99-~99: A comma might be missing here.
Context: ... edge cases and boundary conditions In sum the circuit could look like this: ```r...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)


223-223: Add a comma.

A comma might be missing here.

- validity of the chain state up to that checkpoint without the further need to process/ sync all previous epochs.
+ validity of the chain state up to that checkpoint, without the further need to process/ sync all previous epochs.
Tools
LanguageTool

[uncategorized] ~223-~223: Possible missing comma found.
Context: ... validity of the chain state up to that checkpoint without the further need to process/ sy...

(AI_HYDRA_LEO_MISSING_COMMA)


242-242: Add a comma.

A comma might be missing here.

- last_verified_checkpoint: Option<CheckpointSnark>,
+ last_verified_checkpoint: Option<CheckpointSnark>, 
Tools
LanguageTool

[uncategorized] ~242-~242: Possible missing comma found.
Context: ...kpoint: Option, } ``` accordingly we have to modify the new()-function:...

(AI_HYDRA_LEO_MISSING_COMMA)

adr/adr-001-checkpoint-snarks.md Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Show resolved Hide resolved
adr/adr-001-checkpoint-snarks.md Show resolved Hide resolved
@distractedm1nd distractedm1nd merged commit 19ef6b6 into main Jul 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants