-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wip): ADR for implementing checkpoints via recursive SNARKs #91
Conversation
WalkthroughThe update introduces an architectural decision record (ADR) for implementing a checkpoint system using recursive SNARKs in the Prism blockchain. This aims to enhance light clients' long-term verifiability and synchronization, addressing limitations posed by Celestia's short block storage duration. The solution is structured into two stages: initially focusing on Groth16 SNARKs in Stage 1, followed by the exploration of advanced systems like Nova or zkVMs in Stage 2, ultimately improving sync times and reducing data requirements. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Light Client
participant CH as Checkpoint SNARK
participant SN as SNARK System
participant DB as Block Database
Client->>CH: Request sync from latest checkpoint
CH->>SN: Provide checkpoint SNARK
SN->>DB: Retrieve latest data
DB-->>SN: Return data
SN-->>CH: Return SNARK proof
CH-->>Client: Provide sync data
Client-->>Client: Complete sync
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Outside diff range, codebase verification and nitpick comments (3)
adr/adr-001-checkpoint-snarks.md (3)
99-99
: Add a comma.A comma might be missing here.
- Test edge cases and boundary conditions + Test edge cases and boundary conditions,Tools
LanguageTool
[uncategorized] ~99-~99: A comma might be missing here.
Context: ... edge cases and boundary conditions In sum the circuit could look like this: ```r...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
223-223
: Add a comma.A comma might be missing here.
- validity of the chain state up to that checkpoint without the further need to process/ sync all previous epochs. + validity of the chain state up to that checkpoint, without the further need to process/ sync all previous epochs.Tools
LanguageTool
[uncategorized] ~223-~223: Possible missing comma found.
Context: ... validity of the chain state up to that checkpoint without the further need to process/ sy...(AI_HYDRA_LEO_MISSING_COMMA)
242-242
: Add a comma.A comma might be missing here.
- last_verified_checkpoint: Option<CheckpointSnark>, + last_verified_checkpoint: Option<CheckpointSnark>,Tools
LanguageTool
[uncategorized] ~242-~242: Possible missing comma found.
Context: ...kpoint: Option, } ``` accordingly we have to modify thenew()
-function:...(AI_HYDRA_LEO_MISSING_COMMA)
No description provided.