Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a bug with missing event data on initialization #1692

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Sep 24, 2024

Previously, initializing two LocalHyperdrive objects on existing pools will result in missed event data on the second pool. This adds a flag so that the database always gets updated with all events on pool object initialization.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (3ee7d90) to head (c916e89).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1692      +/-   ##
==========================================
+ Coverage   81.30%   81.92%   +0.61%     
==========================================
  Files          99       99              
  Lines        7650     7652       +2     
==========================================
+ Hits         6220     6269      +49     
+ Misses       1430     1383      -47     
Flag Coverage Δ
unittests 81.92% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui merged commit 9030585 into delvtech:main Sep 24, 2024
5 checks passed
@slundqui slundqui deleted the data-init-hotfix branch September 24, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants