Xdr isolation and un-isolation warning on disconnected endpoint #14751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakatzir
reviewed
Sep 9, 2021
| description: Whether return an error when trying to isolate a disconnected endpoint. | ||
| When sets to false, a warnning will be returned. | ||
| isArray: false | ||
| name: disconnected_endpoint_should_return_error |
There was a problem hiding this comment.
Suggested change
| name: disconnected_endpoint_should_return_error | |
| name: suppress_disconnected_endpoint_error |
| - auto: PREDEFINED | ||
| default: false | ||
| defaultValue: 'True' | ||
| description: Whether return an error when trying to isolate a disconnected endpoint. |
There was a problem hiding this comment.
Suggested change
| description: Whether return an error when trying to isolate a disconnected endpoint. | |
| description: Whether to return an error when trying to isolate a disconnected endpoint. |
| description: Whether return an error when trying to unisolate a disconnected | ||
| endpoint. When sets to false, a warnning will be returned. | ||
| isArray: false | ||
| name: disconnected_endpoint_should_return_error |
There was a problem hiding this comment.
Suggested change
| name: disconnected_endpoint_should_return_error | |
| name: suppress_disconnected_endpoint_error |
| - auto: PREDEFINED | ||
| default: false | ||
| defaultValue: 'True' | ||
| description: Whether return an error when trying to unisolate a disconnected |
There was a problem hiding this comment.
Suggested change
| description: Whether return an error when trying to unisolate a disconnected | |
| description: Whether to return an error when trying to unisolate a disconnected |
|
|
||
| #### Integrations | ||
| ##### Palo Alto Networks Cortex XDR - Investigation and Response | ||
| - Added an argument for the **xdr-isolate-endpoint** and **xdr-unisolate-endpoint** commands whether or not to return an error when the endpoint is disconnected. |
There was a problem hiding this comment.
Suggested change
| - Added an argument for the **xdr-isolate-endpoint** and **xdr-unisolate-endpoint** commands whether or not to return an error when the endpoint is disconnected. | |
| - Added the *suppress_disconnected_endpoint_error* argument for the ***xdr-isolate-endpoint*** and the ***xdr-unisolate-endpoint*** commands which dictates whether to return an error when the endpoint is disconnected. |
|
@yuvalbenshalom can you review this, please? |
yuvalbenshalom
requested changes
Sep 30, 2021
| @@ -789,6 +789,18 @@ script: | |||
| name: endpoint_id | |||
| required: true | |||
| secret: false | |||
| - auto: PREDEFINED | |||
| default: false | |||
| defaultValue: 'True' | |||
There was a problem hiding this comment.
Suggested change
| defaultValue: 'True' | |
| defaultValue: 'true' |
| @@ -805,6 +817,18 @@ script: | |||
| name: endpoint_id | |||
| required: true | |||
| secret: false | |||
| - auto: PREDEFINED | |||
| default: false | |||
| defaultValue: 'True' | |||
There was a problem hiding this comment.
Suggested change
| defaultValue: 'True' | |
| defaultValue: 'true' |
| @@ -1881,7 +1881,7 @@ def insert_cef_alerts_command(client, args): | |||
|
|
|||
| def isolate_endpoint_command(client, args): | |||
| endpoint_id = args.get('endpoint_id') | |||
|
|
|||
| disconnected_should_return_error = argToBoolean(args.get('suppress_disconnected_endpoint_error', True)) | |||
There was a problem hiding this comment.
Suggested change
| disconnected_should_return_error = argToBoolean(args.get('suppress_disconnected_endpoint_error', True)) | |
| disconnected_should_return_error = not argToBoolean(args.get('suppress_disconnected_endpoint_error', False)) |
while it is correct that if suppress_disconnected_endpoint_error does not exist, then disconnected_should_return_error should be true,
if uppress_disconnected_endpoint_error exists, disconnected_should_return_error should get the opposite value of it.
| @@ -1922,7 +1928,7 @@ def isolate_endpoint_command(client, args): | |||
|
|
|||
| def unisolate_endpoint_command(client, args): | |||
| endpoint_id = args.get('endpoint_id') | |||
|
|
|||
| disconnected_should_return_error = argToBoolean(args.get('suppress_disconnected_endpoint_error', True)) | |||
There was a problem hiding this comment.
Suggested change
| disconnected_should_return_error = argToBoolean(args.get('suppress_disconnected_endpoint_error', True)) | |
| disconnected_should_return_error = not argToBoolean(args.get('suppress_disconnected_endpoint_error', False)) |
# Conflicts: # Packs/CortexXDR/Integrations/CortexXDRIR/CortexXDRIR.py # Packs/CortexXDR/Integrations/CortexXDRIR/CortexXDRIR.yml # Packs/CortexXDR/Integrations/CortexXDRIR/README.md
yuvalbenshalom
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
related: https://github.com/demisto/etc/issues/23083
related: #14505
Description
Added a new argument for both isolation and un-isolation actions in order to know if the user wants to get back an error if the endpoint is disconnected. The default is an error. Otherwise, a warning will be returned.
Screenshots
Does it break backward compatibility?
Must have