-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misp V3 - add feed correlations arg #15421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment - your call
@@ -793,6 +799,10 @@ def prepare_args_to_search(controller): | |||
args_to_misp_format['include_correlations'] = 1 if demisto_args.get('include_correlations') == 'true' else 0 | |||
if 'enforceWarninglist' in args_to_misp_format: | |||
args_to_misp_format['enforceWarninglist'] = 1 if demisto_args.get('enforceWarninglist') == 'true' else 0 | |||
if 'include_feed_correlations' in args_to_misp_format: | |||
args_to_misp_format['includeFeedCorrelations'] = 1 if demisto_args.get( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use arg_to_boolean here
The following integrations/tests were collected by the CI build but are currently skipped. The collected tests are related to this pull request and might be critical.:
|
* added include_feed_correlations arg * added include_feed_correlations arg for search events * fix outputs * add docs * add docs * update readme
Status
Related Issues
fixes: https://github.com/demisto/etc/issues/42400
Description
Added a new arg to the misp-search-events command.
Screenshots
Minimum version of Cortex XSOAR
Does it break backward compatibility?