Fixed an OAuth 2.0 Authorization issue in ServiceNow V2 #17337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ured with OAuth 2.0 Authorization
|
Hi @moishce, In my first commit I added a unit test that is failing due to the bug described in the PR's body. In my second commit I added the support for getting an attachment file of a ServiceNow ticket by using an OAuth 2.0 client. In my third commit I added the RN and improved the unit test doc string. Let me know if you have any question or suggestion :) |
ShacharKidor
force-pushed
the
fix_service_now_auth_bug
branch
from
727c636
to
921928a
Compare
Itay4
approved these changes
Jan 30, 2022
| @@ -32,6 +32,12 @@ def __init__(self, credentials: dict, use_oauth: bool = False, client_id: str = | |||
| self.password = credentials.get('password') | |||
| self.auth = (self.username, self.password) | |||
|
|
|||
| if '@' in client_id: # for use in OAuth test-playbook | |||
| self.client_id, refresh_token = client_id.split('@') | |||
| integration_context = get_integration_context() | |||
There was a problem hiding this comment.
is there a reason for that? will there be anything in the context?
There was a problem hiding this comment.
Changed that. thanks!
|
|
||
| #### Integrations | ||
| ##### ServiceNow v2 | ||
| - Fixed the ***servicenow-get-ticket*** command to correctly authorize the request when getting an attachment from a 'ServiceNow' ticket. |
There was a problem hiding this comment.
Suggested change
| - Fixed the ***servicenow-get-ticket*** command to correctly authorize the request when getting an attachment from a 'ServiceNow' ticket. | |
| - Fixed an issue where the ***servicenow-get-ticket*** command failed when to get attachments when using *OAuth Login*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: 46055
Description
The edited TPB:
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have