Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit 42 v2 Feed - Added malicious verdict to fetched indicators #17407

Merged
merged 6 commits into from
Feb 2, 2022

Conversation

ShacharKidor
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: 46149.

Description

Added malicious verdict (score) to fetched indicators.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@ShacharKidor
Copy link
Contributor Author

ShacharKidor commented Feb 1, 2022

Hi @moishce,
In my first commit, I edited an existing unit test that tested the 'parse_indicators' function.
The test failed when I added the malicious score to its expected result list because fetched indicators used to get an unknown verdict.
You can see the build's failure here.

In my second commit I added the fix to 'parse_indicators' function - added malicious verdict (score 3) to the fetched indicators, and as you can see the test passes successfully.

Please let me know if there is something to add or change :)

@ShacharKidor ShacharKidor marked this pull request as ready for review February 1, 2022 13:12
Copy link
Contributor

@jochman jochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. 🧙🏿‍♂️

@ShacharKidor ShacharKidor merged commit 90f2882 into master Feb 2, 2022
@ShacharKidor ShacharKidor deleted the fix_unit_42_atoms_feed_ioc_bug branch February 2, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants