Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoExtract Test - Fixed tasks related to URLs and Domains extractions according to the updated behavior #17723

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

ShacharKidor
Copy link
Contributor

@ShacharKidor ShacharKidor commented Feb 17, 2022

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: 45293

Description

Fixed tasks related to URLs and Domains extractions according to the updated behavior that was defined by the security team:

According to @melamedbn:

  1. A URL that doesn't start with a schema (such as 'https://', 'hxxps://') is not a URL but a Domain. Therefore the condition that was used to check whether the domain: 'www.thisoneshouldnotexisteither4444.com' was extracted to context as a URL by auto-extract was removed.

  2. Domains will be extracted exactly as they are (including the 'www' prefix). For example the domain that should be extracted from this URL: 'http://www.thisurlwillneverexist4444.co.il' is: 'www.thisurlwillneverexist4444.co.il'.
    Therefore 3 conditions were changed in the task that is in charge of verifying domains extraction.

Screenshots

A successful run of the playbook after the fix:
Autoextract_-_Test_Thu_Feb_17_2022

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@ShacharKidor ShacharKidor changed the title AutoExtract Test - Fixed tasks related to URLs and Domains extractions according to the … AutoExtract Test - Fixed tasks related to URLs and Domains extractions according to the updated behavior Feb 17, 2022
@ShacharKidor ShacharKidor merged commit f23b3fb into master Feb 17, 2022
@ShacharKidor ShacharKidor deleted the fix_autoextract_test branch February 17, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants