Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new workflow to update base branch #18847

Merged
merged 9 commits into from
May 3, 2022
Merged

Conversation

Shellyber
Copy link
Contributor

@Shellyber Shellyber commented May 1, 2022

Status

  • Ready

Related Issues

fixes: https://github.com/demisto/etc/issues/47323

Description

A few sentences describing the overall goals of the pull request's commits.

@lgtm-com
Copy link

lgtm-com bot commented May 2, 2022

This pull request introduces 1 alert when merging aae7b27 into 008f5b0 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@Shellyber Shellyber marked this pull request as ready for review May 2, 2022 14:50
@Shellyber
Copy link
Contributor Author

Example workflow run on my forked repo (with the relevant changes to make this work) - https://github.com/Shellyber/content/runs/6259506423?check_suite_focus=true

Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Utils/github_workflow_scripts/sync_contrib_base.py Outdated Show resolved Hide resolved
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Shellyber Shellyber merged commit 0dbeae4 into master May 3, 2022
@Shellyber Shellyber deleted the contribution-workflow branch May 3, 2022 13:37
israelpoli pushed a commit that referenced this pull request May 15, 2024
* Added new workflow to update base branch

* small changes before test

* Added argument to update_base_branch script

* Updated trigger

* Fixed ref branch argument

* changed call location

* Update Utils/github_workflow_scripts/sync_contrib_base.py

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>

* Fixed whitespace validation

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants