Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AppendindicatorFieldWrapper script #18878

Merged
merged 13 commits into from
May 3, 2022

Conversation

ShacharKidor
Copy link
Contributor

@ShacharKidor ShacharKidor commented May 2, 2022

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: 48180.

Description

The AppendindicatorFieldWrapper script was written as a content workaround for the server bug described here: 47577.
The script is a wrapper for the 'AppendindicatorField' script, and it enables adding tags to certain indicators.
The security teams can now use this script to add tags to indicators from a button of an incident layout.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@ShacharKidor ShacharKidor marked this pull request as ready for review May 2, 2022 17:15
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

ShacharKidor and others added 3 commits May 3, 2022 09:33
…torFieldWrapper.yml

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
…torFieldWrapper.py

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented May 3, 2022

This pull request introduces 1 alert when merging a21ccc8 into 28b1b24 - view on LGTM.com

new alerts:

  • 1 for Unused import

@content-bot
Copy link
Collaborator

Comment on lines 42 to 53
args = demisto.args()
indicators_values = argToList(args.get('indicators_values'))
tags = argToList(args.get('tags'))

try:
return_results(run_append_indicator_field_script(demisto.args()))
# Handle missing arguments:
if not indicators_values:
raise Exception('Indicators values were not specified.')
if not tags:
raise Exception('Tags were not specified.')

return_results(run_append_indicator_field_script(indicators_values, tags))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ShacharKidor ShacharKidor merged commit 60edd40 into master May 3, 2022
@ShacharKidor ShacharKidor deleted the tag_indicator_wrapper_script branch May 3, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants