Ciac 604 pr number on rn #19074
Merged
Ciac 604 pr number on rn #19074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JudahSchwartz
force-pushed
the
CIAC-604_pr_number_on_rn
branch
2 times, most recently
from
3ff9025
to
c355344
Compare
Your contributed Wiz pack has been modified on files:Packs/Wiz/Integrations/Wiz/Wiz.py |
ShahafBenYakir
requested changes
May 26, 2022
There was a problem hiding this comment.
Great work.
- Why haven't we tested the get_version_to_pr_numbers function? Let's add a test for it.
- For the future when you are running tests/experiments make sure not to do it on partner packs as it alerts them (see above) that their pack is being modified, let's change the test to another pack.
JudahSchwartz
force-pushed
the
CIAC-604_pr_number_on_rn
branch
from
34f09b8
to
dbbf945
Compare
Noy-Maimon
approved these changes
May 29, 2022
ShahafBenYakir
approved these changes
May 29, 2022
| mocker.patch("os.listdir", return_value=dir_list) | ||
| mocker.patch("os.path.exists", return_value=True) | ||
|
|
||
| class GitMock: |
There was a problem hiding this comment.
Why aren't we uniting this with the other GitMock class?
JudahSchwartz
force-pushed
the
CIAC-604_pr_number_on_rn
branch
from
f7f9855
to
5f57791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have