Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More devcontainer small fixes #19914

Merged
merged 11 commits into from
Jul 11, 2022
Merged

More devcontainer small fixes #19914

merged 11 commits into from
Jul 11, 2022

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Jul 5, 2022

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Fixes issue with windows native (without WSL or Docker volume)
  • Removed venvFolders as we install content dependencies in the base python interpeter.
  • Removed Pylance from extension because it is included in the python extension and is installed anyway. If Pylance is installed before Python, VSCode asks us to reload the window.
  • Added CommonServerUserPython.py in the root folder to make pytest work when importing this module in an integration (it is on gitignore anyway)
  • Moving to docker-compose.yml to get more control.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@ilaner ilaner changed the title make it windows friendly More devcontainer small fixes Jul 5, 2022
@ilaner ilaner requested a review from DeanArbel July 5, 2022 19:27
@ilaner ilaner merged commit 394c343 into master Jul 11, 2022
@ilaner ilaner deleted the devcontainer_native_windows branch July 11, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants