-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed rasterize_html_command #22146
Fixed rasterize_html_command #22146
Conversation
Until now, 'Rasterize Test' (TPB) tested the rasterization of html files by running the 'rasterize-email' command only. |
Link to the unit tests coverage report: |
The following integrations/tests were collected by the CI build but are currently skipped. The collected tests are related to this pull request and might be critical.:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
@ShahafBenYakir - Please force merge the PR. |
Status
Related Issues
fixes: XSUP-18176.
Description
In this PR I fixed the rasterize-html command by changing the input file name to a name including a .html extension.
I also improved the TPB of the integration by adding a test of the rasterize-html command.
In addition I added the 'full_screen' argument to the rasterize-html command.
Screenshots
The results of the rasterize-html command on the same html file before and after the fix:
Before:
After:
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have