migrate to gcp #23690
Merged
migrate to gcp #23690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
dorschw
reviewed
Jan 10, 2023
DeanArbel
reviewed
Jan 10, 2023
| time_to_live = sys.argv[4] | ||
| with open(env_file, 'r') as json_file: | ||
| options = options_handler() | ||
| time_to_live = os.getenv('TIME_TO_LIVE') |
There was a problem hiding this comment.
Why not pass it as part of the options?
esharf
force-pushed
the
eli/migrate_to_gcp
branch
3 times, most recently
from
0bbd31d
to
d67516c
Compare
esharf
force-pushed
the
eli/migrate_to_gcp
branch
4 times, most recently
from
fffc19e
to
93027cb
Compare
esharf
requested review from
ilaner,
daryakoval and
yaakovpraisler
as code owners
esharf
force-pushed
the
eli/migrate_to_gcp
branch
2 times, most recently
from
6012fed
to
98f3c5b
Compare
|
Link to the unit tests coverage report: |
# Conflicts: # poetry.lock # pyproject.toml
DeanArbel
reviewed
Jun 5, 2023
Comment on lines
10
to
11
|
|
||
|
|
There was a problem hiding this comment.
Sure, added just for testing
Comment on lines
+357
to
+359
| if server_numeric_version == 'master': | ||
| logging.info('Server version: Master') | ||
| return default_version |
There was a problem hiding this comment.
Didn't we have a discussion about changing this to use a dedicated field for the server version?
pyproject.toml
Outdated
| @@ -10,9 +10,10 @@ python = "^3.8,<3.11" | |||
| defusedxml = "^0.7.1" | |||
|
|
|||
| [tool.poetry.group.dev.dependencies] | |||
| demisto_sdk = "1.15.5" | |||
| demisto-sdk = {git = "https://github.com/demisto/demisto-sdk.git", branch = "eli/migrate_to_gcp"} | |||
There was a problem hiding this comment.
Please make sure to update this before release
# Conflicts: # Tests/Marketplace/configure_and_install_packs.py # Tests/configure_and_test_integration_instances.py # Tests/scripts/validate_premium_packs.py # poetry.lock # pyproject.toml
# Conflicts: # Packs/PrismaAccess/ReleaseNotes/2_0_5.md # poetry.lock # pyproject.toml
# Conflicts: # poetry.lock # pyproject.toml
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* added * trigger * Update .devcontainer.json name * TEMP * fixup! TEMP * temp * lock * fix * lock * lovk * lockkk * lint fixes * test * test * added 6.11 and removed 6.6 * removed lastline and added prisma so we see a running tpb * typo and poetry lock * fixed machine versions * test * test added rn * lock and conflicts * fix test * lock * fix test * update lock * test * test * removed changes made for testing * lock for release * test --------- Co-authored-by: esharf <esharf@users.noreply.github.com> Co-authored-by: yucohen <yucohen@paloaltonetworks.com>
israelpoli
pushed a commit
that referenced
this pull request
May 15, 2024
* added * trigger * Update .devcontainer.json name * TEMP * fixup! TEMP * temp * lock * fix * lock * lovk * lockkk * lint fixes * test * test * added 6.11 and removed 6.6 * removed lastline and added prisma so we see a running tpb * typo and poetry lock * fixed machine versions * test * test added rn * lock and conflicts * fix test * lock * fix test * update lock * test * test * removed changes made for testing * lock for release * test --------- Co-authored-by: esharf <esharf@users.noreply.github.com> Co-authored-by: yucohen <yucohen@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-704
related: demisto/demisto-sdk#2171
Description
Move build servers to GCP.