New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infoblox BloxOne Threat Defense #24556

Merged

esharf merged 20 commits into master from eli/infoblox

Feb 28, 2023

Contributor

esharf commented Feb 12, 2023 •

edited

Loading

Status

Ready

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-4728

Description

added a new integration Infoblox BloxOne Threat Defense

Minimum version of Cortex XSOAR

6.8.0

Does it break backward compatibility?

No

Must have

Tests
Documentation

esharf requested a review from DeanArbel

February 12, 2023 12:22

esharf force-pushed the eli/infoblox branch from f28a0f5 to a565a49 Compare

February 12, 2023 13:37

DeanArbel requested changes

View reviewed changes

Contributor

DeanArbel left a comment

Mostly looks ok, please note the images need to be updated.
Please add tests.

Packs/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.py Outdated Show resolved Hide resolved

Packs/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.py Outdated Show resolved Hide resolved

Packs/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.py Outdated Show resolved Hide resolved

Packs/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.py Outdated Show resolved Hide resolved

Packs/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.py Outdated Show resolved Hide resolved

Packs/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.py Outdated Show resolved Hide resolved

...fobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/test_data/baseintegration-dummy.json Outdated Show resolved Hide resolved

esharf force-pushed the eli/infoblox branch from 2f16bb5 to d437f68 Compare

February 16, 2023 10:12

Contributor Author

esharf commented Feb 16, 2023

i have fixed the comments.
still need to add Tests and Docs

esharf force-pushed the eli/infoblox branch 2 times, most recently from 918dc25 to 0d376c1 Compare

February 21, 2023 10:54

ShirleyDenkberg self-assigned this

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...s/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.yml Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...loxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense_description.md Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...loxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense_description.md Outdated Show resolved Hide resolved

ShirleyDenkberg reviewed

View reviewed changes

...loxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense_description.md Outdated Show resolved Hide resolved

Contributor

ShirleyDenkberg commented Feb 21, 2023

@esharf You need to create the integration readme and the pack readme. Let me know when these are done and I will review them.

esharf force-pushed the eli/infoblox branch from e66589e to 83700f5 Compare

February 26, 2023 18:36

esharf added the docs-approved label

esharf requested a review from DeanArbel

February 26, 2023 18:44

DeanArbel approved these changes

View reviewed changes

Contributor

DeanArbel left a comment

Great job, just a couple of notes

Packs/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.py Outdated Show resolved Hide resolved

Packs/InfobloxBloxOne/Integrations/InfobloxBloxOneThreatDefense/InfobloxBloxOneThreatDefense.py Outdated Show resolved Hide resolved

esharf and others added 19 commits

February 28, 2023 09:14


          small fix for demistomock.py

699b5dd


          added all

c671fc7


          fixed validation

e7b17c1


          added outputs descriptions and final fixes

e5452d4


          done demo

c58bade


          TEMP

53ff3bd


          fixed CR comments and latest update

9066f6f


          added tests + CR

0f030ed


          added Author_image.png

19817c1


          fixed secret

8bafb47


          fixed linters

3b29346


          Apply suggestions from docs review

2eee74c

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>


          fixed linters

54dd268


          added docs

de52013


          final CR

2f71892


          fixup! final CR

9583db3


          short build

3ffe37f


          fixed readme

6c611ce


          fixed UT

08d40bd

esharf force-pushed the eli/infoblox branch from 84f13b9 to 08d40bd Compare

February 28, 2023 07:21


          fixup! fixed UT

dce12d3

Contributor

xsoar-bot commented Feb 28, 2023

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/5729a128-a145-4d4c-8f04-d45d73965412/artifacts/0/artifacts/coverage_report/html/index.html

esharf merged commit b70f8aa into master

esharf deleted the eli/infoblox branch

February 28, 2023 11:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels