Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ParseEmailFilesV2] - fix chinese chars decoding problem #25154

Merged
merged 3 commits into from
Mar 8, 2023
Merged

[ParseEmailFilesV2] - fix chinese chars decoding problem #25154

merged 3 commits into from
Mar 8, 2023

Conversation

GuyAfik
Copy link
Contributor

@GuyAfik GuyAfik commented Mar 8, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed an issue where an eml file containing chinese characters was not decoded correctly.

@GuyAfik GuyAfik changed the title Parse email files v2 update [ParseEmailFilesV2] - fix chinese chars decoding problem Mar 8, 2023
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/01bdbbf8-abc8-42bf-8cda-44fb166100f3/artifacts/0/artifacts/coverage_report/html/index.html

Shellyber
Shellyber approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@GuyAfik GuyAfik merged commit 0f15c4c into master Mar 8, 2023
@GuyAfik GuyAfik deleted the parse_email_files_v2_update branch March 8, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shellyber Shellyber Shellyber approved these changes

@MLainer1 MLainer1 Awaiting requested review from MLainer1

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuyAfik @xsoar-bot @Shellyber