Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplunkPy: raise error in case error msg return from Splunk #33848

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

ilappe
Copy link
Contributor

@ilappe ilappe commented Apr 9, 2024

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-35748

Description

Splunk return status 200 even if there is error in the search query
but the response contained error message in the response body

image

Fix:
raise error in case this error message is returned.

@ilappe ilappe requested a review from DeanArbel April 9, 2024 11:25
@ilappe ilappe self-assigned this Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/SplunkPy/Integrations/SplunkPy
   SplunkPy.py139540770%112–113, 151, 153, 178–179, 183–186, 188–189, 193–196, 219, 230, 304, 308–310, 313–316, 343–345, 355, 489, 491, 593–594, 600, 621, 640–642, 644, 673, 686–691, 712–713, 715–717, 719, 721, 797–802, 804, 808–809, 974–975, 978–990, 992, 994, 1021–1030, 1065–1066, 1068, 1086, 1132–1133, 1135, 1139, 1145, 1148–1149, 1181–1183, 1191, 1250–1252, 1254–1255, 1317, 1349, 1402–1403, 1469, 1500–1502, 1504, 1529–1530, 1534, 1537, 1540–1548, 1551–1552, 1554, 1556–1557, 1587–1589, 1591, 1593–1594, 1596–1600, 1602–1604, 1606, 1614, 1616–1619, 1623–1631, 1633–1634, 1802, 1805, 1808, 1811, 1814–1817, 1819, 1823–1826, 1829, 1831–1836, 1838, 1964, 1992, 1996, 2005, 2015, 2019, 2040, 2042, 2044, 2046, 2066, 2069, 2074–2078, 2086, 2088–2090, 2132, 2160, 2208, 2214, 2218–2223, 2225–2227, 2229–2230, 2232, 2234–2236, 2270, 2278–2280, 2282–2283, 2285, 2296, 2303–2307, 2311, 2313, 2321–2329, 2331, 2333–2336, 2338–2339, 2370–2375, 2383–2386, 2389–2392, 2407–2408, 2410–2415, 2417, 2427, 2431–2432, 2434, 2446, 2467, 2482, 2494, 2501–2503, 2505–2506, 2523–2525, 2548, 2555–2559, 2565–2566, 2574–2575, 2591–2595, 2598, 2600, 2606–2613, 2615–2616, 2618–2619, 2625–2633, 2635–2636, 2642–2643, 2649–2650, 2652–2654, 2656, 2661–2668, 2670, 2675, 2682–2685, 2694–2697, 2701–2704, 2719, 2721–2722, 2724–2725, 2727, 2736, 2740–2747, 2752, 2768–2769, 2776–2779, 2807–2814, 2818–2819, 2821–2826
TOTAL139540770% 

Tests Skipped Failures Errors Time
158 0 💤 0 ❌ 0 🔥 2.738s ⏱️

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ilappe ilappe merged commit 771d916 into master Apr 10, 2024
17 checks passed
@ilappe ilappe deleted the ilappe/XSUP-35748/raise_error branch April 10, 2024 11:23
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants