-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tim Feed Threatfox #35748
Merged
Merged
Tim Feed Threatfox #35748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml
Outdated
Show resolved
Hide resolved
JasBeilin
reviewed
Aug 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job, see my comments so we can move forward :)
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.py
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.py
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py
Outdated
Show resolved
Hide resolved
Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py
Outdated
Show resolved
Hide resolved
…est.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
…est.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
…est.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
…est.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
…est.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
JasBeilin
approved these changes
Aug 19, 2024
maimorag
pushed a commit
that referenced
this pull request
Aug 27, 2024
* run init * start API call function * api request * continue * finish API func with unit tests * description * continue * more * finish get-indicators command * add test_module function * start fetch command * start fetch-indicators * almost finished * almost finished * validate arg * nicer code and fixes * remove duplicate tags * typing * typing and descriptions * fetch last run and little fixes * tests * more unit tests * more unit tests and fix fetch * more * more tests and testaybook * pre commit * remove the dev * pack readme * Update Packs/FeedThreatFox/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/FeedThreatFox/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * code review fixes * exception * ThreatFox version * add indicator example * CR * dateparser * two fixes * change malware error * tag and malware description * pre commit * import get_value * parsed_date * pre commit * long lines * / * more outopep * ruff * malicious * malicious to bad * validate * updated docker image * add test playbook to yml * docker image * required: true * conf json * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/README.md Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * pre commit * delete test playbook * delete test playbook --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Sep 10, 2024
* run init * start API call function * api request * continue * finish API func with unit tests * description * continue * more * finish get-indicators command * add test_module function * start fetch command * start fetch-indicators * almost finished * almost finished * validate arg * nicer code and fixes * remove duplicate tags * typing * typing and descriptions * fetch last run and little fixes * tests * more unit tests * more unit tests and fix fetch * more * more tests and testaybook * pre commit * remove the dev * pack readme * Update Packs/FeedThreatFox/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/FeedThreatFox/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * code review fixes * exception * ThreatFox version * add indicator example * CR * dateparser * two fixes * change malware error * tag and malware description * pre commit * import get_value * parsed_date * pre commit * long lines * / * more outopep * ruff * malicious * malicious to bad * validate * updated docker image * add test playbook to yml * docker image * required: true * conf json * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/README.md Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.py Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com> * pre commit * delete test playbook * delete test playbook --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-976
Description
A new Feed integration
Must have