Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim Feed Threatfox #35748

Merged
merged 73 commits into from
Aug 19, 2024
Merged

Tim Feed Threatfox #35748

merged 73 commits into from
Aug 19, 2024

Conversation

YaelShamai
Copy link
Contributor

@YaelShamai YaelShamai commented Aug 4, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-976

Description

A new Feed integration

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Aug 4, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/FeedThreatFox/Integrations/FeedThreatFox
   FeedThreatFox.py1694175%38–39, 92–93, 292, 311–313, 346, 355, 364–369, 371, 381, 383–389, 391–392, 394, 396–398, 400–401, 403–404, 408–411, 413–414
TOTAL1694175% 

Tests Skipped Failures Errors Time
176 0 💤 0 ❌ 0 🔥 8.999s ⏱️

Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job, see my comments so we can move forward :)

YaelShamai and others added 11 commits August 18, 2024 14:45
…est.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
…est.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
…est.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
…est.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
…est.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
@YaelShamai YaelShamai merged commit 0cb64d5 into master Aug 19, 2024
16 checks passed
@YaelShamai YaelShamai deleted the yshamai-tim-feed-threatfox branch August 19, 2024 10:02
maimorag pushed a commit that referenced this pull request Aug 27, 2024
* run init

* start API call function

* api request

* continue

* finish API func with unit tests

* description

* continue

* more

* finish get-indicators command

* add test_module function

* start fetch command

* start fetch-indicators

* almost finished

* almost finished

* validate arg

* nicer code and fixes

* remove duplicate tags

* typing

* typing and descriptions

* fetch last run and little fixes

* tests

* more unit tests

* more unit tests and fix fetch

* more

* more tests and testaybook

* pre commit

* remove the dev

* pack readme

* Update Packs/FeedThreatFox/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/FeedThreatFox/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* code review fixes

* exception

* ThreatFox version

* add indicator example

* CR

* dateparser

* two fixes

* change malware error

* tag and malware description

* pre commit

* import get_value

* parsed_date

* pre commit

* long lines

* /

* more outopep

* ruff

* malicious

* malicious to bad

* validate

* updated docker image

* add test playbook to yml

* docker image

* required: true

* conf json

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/README.md

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* pre commit

* delete test playbook

* delete test playbook

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
* run init

* start API call function

* api request

* continue

* finish API func with unit tests

* description

* continue

* more

* finish get-indicators command

* add test_module function

* start fetch command

* start fetch-indicators

* almost finished

* almost finished

* validate arg

* nicer code and fixes

* remove duplicate tags

* typing

* typing and descriptions

* fetch last run and little fixes

* tests

* more unit tests

* more unit tests and fix fetch

* more

* more tests and testaybook

* pre commit

* remove the dev

* pack readme

* Update Packs/FeedThreatFox/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/FeedThreatFox/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* code review fixes

* exception

* ThreatFox version

* add indicator example

* CR

* dateparser

* two fixes

* change malware error

* tag and malware description

* pre commit

* import get_value

* parsed_date

* pre commit

* long lines

* /

* more outopep

* ruff

* malicious

* malicious to bad

* validate

* updated docker image

* add test playbook to yml

* docker image

* required: true

* conf json

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox_test.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/README.md

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/FeedThreatFox/Integrations/FeedThreatFox/FeedThreatFox.yml

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* pre commit

* delete test playbook

* delete test playbook

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants