Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FindEmailCampaign #35863

Merged
merged 9 commits into from
Aug 22, 2024
Merged

Fix FindEmailCampaign #35863

merged 9 commits into from
Aug 22, 2024

Conversation

YuvHayun
Copy link
Contributor

@YuvHayun YuvHayun commented Aug 14, 2024 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: XSUP-40566

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

maimorag
maimorag approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@maimorag maimorag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Campaign/Scripts/FindEmailCampaign
   FindEmailCampaign.py39216458%114, 125–126, 134, 178, 187–189, 193, 195–197, 201–206, 208, 210, 212–216, 218–219, 222–224, 230, 236–237, 255–256, 267–268, 283–285, 287–288, 306–309, 311–312, 329, 333–339, 343–344, 346–351, 353–372, 426, 428–429, 447–448, 454–455, 472–473, 477–478, 480–482, 484–485, 489–496, 498, 500–501, 507, 509–514, 516, 520–528, 533–541, 546–551, 557–566, 568–578
TOTAL39216458% 

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 21.401s ⏱️

@YuvHayun YuvHayun changed the title add logs Fix FindEmailCampaign Aug 20, 2024
AradCarmi
AradCarmi approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@AradCarmi AradCarmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

Packs/Campaign/ReleaseNotes/3_4_8.md Show resolved Hide resolved
@YuvHayun YuvHayun force-pushed the add_logs_to_findemailcampaign branch from 9ff3939 to b263bce Compare August 22, 2024 10:23
@YuvHayun YuvHayun merged commit 28c2898 into master Aug 22, 2024
15 of 16 checks passed
@YuvHayun YuvHayun deleted the add_logs_to_findemailcampaign branch August 22, 2024 12:23
maimorag pushed a commit that referenced this pull request Aug 27, 2024
@YuvHayun @maimorag
Fix FindEmailCampaign (#35863)
f2ac463 
* add logs

* add fix

* Fixed an issue where script failed in cases where a context key with nested lists were received

* added rn

* cr fixes

* cr fixes

* update docker
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
@YuvHayun @xsoar-bot
Fix FindEmailCampaign (demisto#35863)
e8ecd5f 
* add logs

* add fix

* Fixed an issue where script failed in cases where a context key with nested lists were received

* added rn

* cr fixes

* cr fixes

* update docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AradCarmi AradCarmi AradCarmi approved these changes

@maimorag maimorag maimorag approved these changes

@jlevypaloalto jlevypaloalto Awaiting requested review from jlevypaloalto jlevypaloalto is a code owner

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuvHayun @AradCarmi @maimorag