Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortigate fix #35939

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Fortigate fix #35939

merged 6 commits into from
Aug 19, 2024

Conversation

eyalpalo
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed an issue with fortigate-list-firewall-policies command which caused all policies to be displayed when filtering by a policyName that did not have any matches.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Aug 19, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/FortiGate/Integrations/FortiGate
   FortiGate.py142039472%154, 156–158, 166–169, 179, 191–192, 194–195, 200–203, 206, 208–209, 217, 221–222, 246, 2299, 2541, 2810, 2845–2846, 2848–2851, 2853–2854, 2856, 2858, 3446–3448, 3619–3620, 4221, 4393, 4484, 4561, 4564, 4863, 4900, 4922–4926, 4928, 4930–4931, 4933, 4935–4939, 4947, 4956–4957, 4972–4978, 4980–4981, 4983, 4991–4998, 5000, 5002, 5017–5020, 5022, 5024–5026, 5028, 5030, 5045–5049, 5051, 5053–5059, 5063, 5065, 5080–5084, 5086, 5088, 5094, 5096, 5098, 5115–5122, 5124–5126, 5128–5137, 5139–5146, 5150, 5152, 5169–5172, 5174, 5176–5177, 5179, 5181, 5196–5202, 5204, 5206–5207, 5213, 5220, 5222, 5237–5240, 5242, 5244–5250, 5252–5253, 5268, 5270–5274, 5276–5278, 5280–5289, 5291–5292, 5294–5297, 5299, 5301, 5303, 5305, 5322–5323, 5325, 5327, 5329–5330, 5332, 5349–5354, 5356, 5374, 5376–5381, 5389–5391, 5393–5401, 5403, 5418, 5434, 5436, 5464–5466, 5468–5478, 5480, 5494–5495, 5497, 5511, 5525, 5527, 5549–5557, 5559, 5563–5564, 5570–5573, 5575–5579, 5581–5582, 5584, 5586–5587, 5589–5590, 5599–5601, 5610–5612, 5614–5622, 5624, 5639, 5655, 5657, 5674–5678, 5680, 5682–5683, 5685, 5687, 5702–5704, 5706, 5708–5709, 5711, 5713, 5730–5740, 5746–5748, 5754–5758, 5769–5771, 5773, 5775–5777, 5779–5780, 5784–5785, 5787–5788, 5790–5791, 5793, 5795, 5839, 5859–5860, 5869–5870, 5872, 5874–5879, 5881, 5883–5884, 5886–5887, 5889
TOTAL142039472% 

Tests Skipped Failures Errors Time
432 0 💤 0 ❌ 0 🔥 9.754s ⏱️

Packs/FortiGate/ReleaseNotes/2_0_3.md Outdated Show resolved Hide resolved
@eyalpalo eyalpalo merged commit 545493a into master Aug 19, 2024
16 checks passed
@eyalpalo eyalpalo deleted the fortigate branch August 19, 2024 16:05
maimorag pushed a commit that referenced this pull request Aug 27, 2024
* test

* fix

* rn

* docker

* rn

* rn
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
* test

* fix

* rn

* docker

* rn

* rn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants