Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add events_from_decider_list to coreIR #36022

Merged
merged 11 commits into from
Aug 28, 2024

Conversation

YuvHayun
Copy link
Contributor

@YuvHayun YuvHayun commented Aug 26, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-11604

Description

  • Added the alter_events_from_decider argument, use this argument to obtain events_from_decider context path as a list (for improved for playbook automation) rather than a dictionary (The original raw data).

@YuvHayun YuvHayun added the bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url label Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/CoreIRApiModule
   CoreIRApiModule.py167326883%242, 285, 288, 293, 307, 338, 345, 359, 363, 367, 374, 381, 388, 395, 416, 462, 467, 508, 523, 534, 546, 605–606, 612–617, 642, 648, 654, 666, 676, 682, 701, 713, 719, 725, 737, 747, 753, 789, 803, 828, 857, 873, 875, 983, 1013, 1016, 1026, 1095, 1101, 1121, 1127, 1129, 1156, 1172, 1358, 1382, 1388, 1401, 1403–1404, 1406, 1412–1413, 1419–1420, 1426, 1433–1434, 1467, 1469, 1515, 1522, 1529, 1535, 1541, 1548, 1555, 1565, 1595, 1671–1674, 1676–1682, 1687, 1692–1695, 1697–1698, 1700–1701, 1703–1707, 1709–1710, 1712, 1716, 1723–1724, 1739–1740, 1756, 1761, 1769, 1817–1819, 1823, 1826, 1850, 1935, 1941, 1945, 1949, 1954, 1960, 1972–1973, 1979, 1984, 1990, 1993–1995, 2027, 2030–2033, 2147, 2220, 2226, 2230, 2234, 2237, 2441, 2455–2457, 2460, 2513–2515, 2518, 2672, 2683, 2686–2688, 2692–2695, 2699–2700, 2706, 2708–2712, 2716, 2722, 2724–2725, 2727, 2731–2734, 2736, 2743, 2745–2746, 2749–2753, 2756, 2758, 2760, 2762–2765, 2769–2770, 2772–2777, 2779, 2810, 2985–2988, 2992–2993, 3004, 3104, 3133, 3135, 3137, 3381–3382, 3474–3476, 3484, 3505, 3624–3627, 3714, 3722, 3726–3727, 3785–3787, 3793, 3832, 3846, 3853, 3860, 3902, 3909, 3916, 3923, 3930, 4134, 4170–4173, 4175–4177, 4280, 4314, 4320, 4327, 4329, 4336, 4338, 4356, 4379
Packs/Core/Integrations/CoreIOCs
   CoreIOCs.py3088173%53, 61, 63, 73, 89, 94, 111, 173–174, 235, 264, 294–301, 303–305, 307–308, 316, 337, 342, 351, 355–359, 363–364, 366, 370–372, 383, 396–407, 409, 433–441, 448–453, 459–468, 470–472
Packs/Core/Integrations/CortexCoreIR
   CortexCoreIR.py551278%36–39, 41, 44, 47, 54, 59, 62, 64, 108
Packs/CortexXDR/Integrations/CortexXDRIR
   CortexXDRIR.py6498786%61, 69, 73–75, 146–147, 208–212, 214, 217, 220, 224, 250–254, 256, 263–266, 277, 280, 283, 289, 292, 318, 323, 331, 333, 336–340, 342, 425–430, 479, 517, 532–533, 550, 560, 620, 623, 650, 657, 659, 736–737, 739, 792, 981–983, 986, 989, 994, 1029, 1037, 1060, 1088–1089, 1140, 1149, 1151–1153, 1156, 1159–1160, 1197–1200, 1232, 1249
Packs/ctf01/Integrations/CortexXDRIRCTF
   CortexXDRIRCTF.py4644640%1–7, 10, 12–14, 16–18, 20, 37, 44, 52–57, 60–68, 71–72, 75–76, 79–80, 83–88, 91–98, 101, 109–121, 123–125, 128, 130, 134–138, 140, 143, 145, 153, 159, 163, 166–171, 173, 179–182, 184, 186, 208–209, 211, 216–217, 219–220, 224–225, 230–232, 238–239, 245–246, 251, 256–260, 263–264, 270–271, 277–278, 284–285, 291–292, 298–299, 301, 307, 309, 311, 319, 324, 331, 333, 335–340, 342, 344–345, 351, 358, 360–361, 367, 375, 377–378, 384, 387–389, 392, 400–402, 404, 408–410, 412, 415–416, 418–423, 426–427, 429, 432, 441–443, 445–447, 449–450, 453, 455–456, 545–552, 554, 556–557, 560, 562–563, 565, 567–568, 570, 572, 577, 580, 582–589, 591–595, 597, 599–607, 614, 616, 629, 632–636, 640–641, 646–648, 650, 652, 654, 656, 669, 671, 678, 681–685, 687, 690, 692, 695, 697, 704, 707–709, 711–713, 715–716, 718–720, 722–723, 725, 727–728, 730, 733–737, 739, 742, 746–751, 754–758, 767–768, 770–773, 775, 778–781, 783–784, 786, 789–791, 793, 795–797, 799, 801–804, 806, 809–811, 813–814, 817, 819, 823–824, 826–827, 829, 832, 835–836, 840, 843, 845–848, 850, 852, 858, 863, 868–869, 872–873, 875–877, 880, 883, 888, 894, 900, 1154, 1157, 1173–1174, 1178–1179, 1181–1182, 1184–1186, 1188–1189, 1194–1195, 1200, 1206–1208, 1210, 1212–1213, 1217–1218, 1220, 1222–1223, 1225–1227, 1233–1234, 1237–1238, 1240–1241, 1243–1245, 1247–1249, 1252, 1254–1255, 1257, 1259, 1261, 1264–1265, 1267–1268, 1273, 1278, 1281, 1283, 1291–1295, 1298, 1306, 1310, 2223–2226, 2228–2229, 2231, 2233, 2245, 2254–2256, 2258–2263, 2265, 2269, 2271, 2274, 2283, 2286–2291, 2293–2294, 2300, 2304, 2306, 2308, 2312
TOTAL314991271% 

Tests Skipped Failures Errors Time
258 4 💤 0 ❌ 0 🔥 19.022s ⏱️

Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Make sure to make the fixes of an argument name, description, variable changes in all necessary places

Packs/Core/Integrations/CortexCoreIR/CortexCoreIR.yml Outdated Show resolved Hide resolved
Packs/Core/Integrations/CortexCoreIR/CortexCoreIR.yml Outdated Show resolved Hide resolved
Packs/CortexXDR/Integrations/CortexXDRIR/CortexXDRIR.yml Outdated Show resolved Hide resolved
Packs/Core/Integrations/CortexCoreIR/CortexCoreIR.yml Outdated Show resolved Hide resolved
Packs/CortexXDR/ReleaseNotes/6_1_66.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Packs/CortexXDR/ReleaseNotes/6_1_66.md Outdated Show resolved Hide resolved
Packs/Core/ReleaseNotes/3_0_55.md Outdated Show resolved Hide resolved
YuvHayun and others added 2 commits August 27, 2024 19:06
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
@YuvHayun
Copy link
Contributor Author

@ShahafBenYakir need force merge - failing on missing RN, didn't update RN for all packs because the update in the API Module is relevant only for some one the packs using this API Module.

@YuvHayun YuvHayun added the ForceMerge Forcing the merge of the PR despite the build status label Aug 27, 2024
@ShahafBenYakir ShahafBenYakir merged commit fc1c19e into master Aug 28, 2024
16 of 18 checks passed
@ShahafBenYakir ShahafBenYakir deleted the add_events_from_decider_list_to_core_IR branch August 28, 2024 07:53
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
* changes

* added rn

* added arg

* updated rns

* fixes

* added test

* pre commit fixes

* cr fixes

* Update Packs/CortexXDR/ReleaseNotes/6_1_66.md

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>

* Update Packs/Core/ReleaseNotes/3_0_55.md

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>

---------

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants