Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] - Parent Playbook Input Typo #36450

Merged
merged 5 commits into from
Sep 25, 2024
Merged

[ASM] - Parent Playbook Input Typo #36450

merged 5 commits into from
Sep 25, 2024

Conversation

johnnywilkes
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-11327

Description

AcceptedRiskDs is misspelled in "Cortex ASM - ASM Alert" as it should be AcceptedRiskIDs instead.

Must have

  • Tests
  • Documentation

@johnnywilkes johnnywilkes marked this pull request as draft September 23, 2024 20:34
@johnnywilkes
Copy link
Contributor Author

@ShirleyDenkberg , please review

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Sep 23, 2024
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_ASM-EXPANDR-11327 September 23, 2024 20:35
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @israelpoli will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @johnnywilkes, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Sep 23, 2024
@johnnywilkes
Copy link
Contributor Author

@capanw / @BigEasyJ , please review

@ShirleyDenkberg
Copy link
Contributor

@capanw @israelpoli @tomer-pan Doc review completed.

@johnnywilkes @ShirleyDenkberg
Update Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_52.md
46046a4 
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@johnnywilkes johnnywilkes marked this pull request as ready for review September 24, 2024 12:29
@johnnywilkes
Copy link
Contributor Author

@tomer-pan / @israelpoli , this PR has been approved by Xpanse, please merge when possible

israelpoli
israelpoli approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@israelpoli israelpoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@israelpoli israelpoli merged commit 03e6996 into demisto:contrib/PaloAltoNetworks_ASM-EXPANDR-11327 Sep 25, 2024
16 checks passed
@content-bot content-bot mentioned this pull request Sep 25, 2024
Merged
5 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

israelpoli added a commit that referenced this pull request Sep 25, 2024
@content-bot @johnnywilkes
@ShirleyDenkberg @israelpoli
[ASM] - Parent Playbook Input Typo (#36450) (#36499)
26983da 
* fix typo

* RN

* RN try 2

* Update Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_52.md



---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com>
sharonfi99 pushed a commit that referenced this pull request Sep 29, 2024
@content-bot @johnnywilkes
@ShirleyDenkberg @israelpoli @sharonfi99
[ASM] - Parent Playbook Input Typo (#36450) (#36499)
cdcc8e5 
* fix typo

* RN

* RN try 2

* Update Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_52.md



---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@israelpoli israelpoli israelpoli approved these changes

@capanw capanw capanw approved these changes

@tomer-pan tomer-pan Awaiting requested review from tomer-pan

Assignees

@israelpoli israelpoli

@tomer-pan tomer-pan

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@johnnywilkes @content-bot @ShirleyDenkberg @israelpoli @capanw @tomer-pan