-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Async<'value voption> support to asyncOptionCE #226
base: master
Are you sure you want to change the base?
Conversation
it does so by converting your voption to option, which is how OptionCE does it
Add Async<'value voption> support to asyncOptionCE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Could you also add corresponding tests in the test suite? Tests for let! and return! should be sufficient.
Added tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing on formatting, could you run the format build target FormatCode
?
We can currently use
let!
to bind to either option or value option inoption {}
computation expression, I am making asyncOption to be able to do this too, it couldn't before I made it to.it does so by converting your voption to option, which is how OptionCE does it
#225 (comment)