Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Async<'value voption> support to asyncOptionCE #226

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Xyncgas
Copy link

@Xyncgas Xyncgas commented Aug 4, 2023

We can currently use let! to bind to either option or value option in option {} computation expression, I am making asyncOption to be able to do this too, it couldn't before I made it to.

it does so by converting your voption to option, which is how OptionCE does it
#225 (comment)

it does so by converting your voption to option, which is how OptionCE does it
Add Async<'value voption> support to asyncOptionCE
Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you also add corresponding tests in the test suite? Tests for let! and return! should be sufficient.

@Xyncgas
Copy link
Author

Xyncgas commented Aug 7, 2023

Added tests

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing on formatting, could you run the format build target FormatCode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants