Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Option functions and Added Missing Documentation #246

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

1eyewonder
Copy link
Contributor

Proposed Changes

Added the following functions to the Option module to better match what we can find in the Result module. I thought it may make the functionality feel more complete for users. I'm okay removing, if we find these functions unnecessary.

Functions Added

  1. map2
  2. map3
  3. ignore
  4. teeSome
  5. teeNone
  6. teeIf

The rest of the changes are adding xml comments and documentation for the site.

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thank you so much for this!

@TheAngryByrd TheAngryByrd merged commit 405265e into demystifyfp:master Jan 10, 2024
25 checks passed
TheAngryByrd added a commit that referenced this pull request Jan 10, 2024
- [Added Option functions and Added Missing Documentation](#246) Credits @1eyewonder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants