Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation for new gender attributes #83

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

jjinkxy
Copy link
Collaborator

@jjinkxy jjinkxy commented May 16, 2024

Ref https://github.com/denkungsart/filmmakers/issues/5376

  • add explanations about new field "new_gender"
  • add explanations about new field "gender_searchablity"
  • add explanations about query parameter "gender_new"
  • include examples in JSON

@jjinkxy jjinkxy self-assigned this May 16, 2024
…chability field

* Update `long_gender` field to `gender_new`
* Expand on what values the gender filter query can accept
* Add documentation for gender_searchability field
@andreas-venturini andreas-venturini changed the title Update API due to gender and temp "long_gender" changes Add documentation for new gender attributes May 21, 2024
@jjinkxy jjinkxy force-pushed the filmmakers-5376-new-gender-concept branch from 433b906 to 5a5148c Compare May 21, 2024 10:53
Copy link
Member

@andreas-venturini andreas-venturini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, needs some minor wording changes but I'll do these myself before merging

@jjinkxy jjinkxy changed the title Add documentation for new gender attributes Adds documentation for new gender attributes Jun 10, 2024
* Old values still work, but are not documented anymore
@andreas-venturini andreas-venturini self-requested a review July 8, 2024 12:29
@jjinkxy jjinkxy force-pushed the filmmakers-5376-new-gender-concept branch from 2ba3d8c to e2fe9fa Compare July 10, 2024 09:30
@jjinkxy jjinkxy force-pushed the filmmakers-5376-new-gender-concept branch from e2fe9fa to db419a1 Compare July 10, 2024 09:30
@andreas-venturini andreas-venturini merged commit 5d8f678 into main Jul 10, 2024
10 checks passed
@andreas-venturini andreas-venturini deleted the filmmakers-5376-new-gender-concept branch July 10, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants