Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): check resource exists before close #23655

Merged
merged 1 commit into from
May 2, 2024

Conversation

satyarohith
Copy link
Member

The patch fixes grpc deadline example:

➜deno run -A deadline/client.js
Warning: Not implemented: Http2Session.socket
[1] wanted = OK got = OK
Warning: Not implemented: Http2Session.socket
[2] wanted = DEADLINE_EXCEEDED got = DEADLINE_EXCEEDED
Warning: Not implemented: Http2Session.socket
error: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'bodyRid')
    at node:http2:888:96
    at eventLoopTick (ext:core/01_core.js:207:9)

Fixed:

➜  examples git:(es_examples) denod run -A deadline/client.js
Warning: Not implemented: Http2Session.socket
[1] wanted = OK got = OK
Warning: Not implemented: Http2Session.socket
[2] wanted = DEADLINE_EXCEEDED got = DEADLINE_EXCEEDED
Warning: Not implemented: Http2Session.socket
[3] wanted = OK got = OK
Warning: Not implemented: Http2Session.socket
[4] wanted = DEADLINE_EXCEEDED got = DEADLINE_EXCEEDED
Warning: Not implemented: Http2Session.socket
[5] wanted = OK got = OK
Warning: Not implemented: Http2Session.socket
[6] wanted = DEADLINE_EXCEEDED got = DEADLINE_EXCEEDED

I added a smoke test in the internal repo.

@satyarohith satyarohith merged commit 811280a into denoland:main May 2, 2024
17 checks passed
@satyarohith satyarohith deleted the fix_grpc_deadline branch May 2, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants