Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): prevent panic in http2.connect with uppercase header names #24780

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(ext/node): prevent panic in http2.connect with uppercase header names #24780

merged 1 commit into from
Jul 29, 2024

Conversation

satyarohith
Copy link
Member

Closes #24678

@satyarohith satyarohith enabled auto-merge (squash) July 29, 2024 11:29
bartlomieju
bartlomieju approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this test panics on main. LGTM

@satyarohith satyarohith merged commit 8bab761 into denoland:main Jul 29, 2024
17 checks passed
@satyarohith satyarohith deleted the fix_24678 branch July 29, 2024 12:18
crowlKats pushed a commit that referenced this pull request Jul 31, 2024
@satyarohith @crowlKats
fix(ext/node): prevent panic in http2.connect with uppercase header n…
a3fb3bc 
…ames (#24780)

Closes #24678

(cherry picked from commit 8bab761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic with npm:fetch-http2 when using headers with Uppercase characters
2 participants
@satyarohith @bartlomieju