Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): handle node child_process with --v8-options flag #24804

Merged
merged 2 commits into from
Jul 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ext/node/polyfills/internal/child_process.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1030,6 +1030,7 @@ const kNodeFlagsMap = new Map([
["--v8-pool-size", kLongArg],
]);
const kDenoSubcommands = new Set([
"add",
"bench",
"bundle",
"cache",
Expand All @@ -1046,6 +1047,7 @@ const kDenoSubcommands = new Set([
"install",
"lint",
"lsp",
"publish",
"repl",
"run",
"tasks",
Expand Down Expand Up @@ -1092,6 +1094,12 @@ function toDenoArgs(args: string[]): string[] {
let isLongWithValue = false;
let flagValue;

if (flag === "--v8-options") {
// If --v8-options is passed, it should be replaced with --v8-flags="--help".
denoArgs.push("--v8-flags=--help");
continue;
}

if (flagInfo === undefined) {
// If the flag was not found, it's either not a known flag or it's a long
// flag containing an '='.
Expand Down
1 change: 1 addition & 0 deletions tests/registry/npm/v8flags/registry.json

Large diffs are not rendered by default.

Binary file added tests/registry/npm/v8flags/v8flags-4.0.1.tgz
Binary file not shown.
5 changes: 5 additions & 0 deletions tests/specs/run/npm_v8flags/__test__.jsonc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"args": "run -A main.js",
"output": "main.out",
"exitCode": 0
}
17 changes: 17 additions & 0 deletions tests/specs/run/npm_v8flags/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import v8flags from "npm:v8flags@4.0.1";

const flags = await new Promise((resolve, reject) => {
v8flags((err, flags) => {
if (err) {
reject(err);
} else {
resolve(flags);
}
});
});

if (flags.length < 100) {
throw new Error("Expected at least 100 flags");
}

console.log("ok");
3 changes: 3 additions & 0 deletions tests/specs/run/npm_v8flags/main.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Download http://localhost:4260/v8flags
Download http://localhost:4260/v8flags/v8flags-4.0.1.tgz
ok