Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: add stub for child_process.execSync #2513

Merged
merged 1 commit into from
Aug 11, 2022
Merged

node: add stub for child_process.execSync #2513

merged 1 commit into from
Aug 11, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 11, 2022 •
edited
Loading

Vite complains about missing API but never uses it :)

@bartlomieju bartlomieju requested a review from kt3k as a code owner August 11, 2022 09:54
kt3k
kt3k approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit 60207ba into denoland:main Aug 11, 2022
@bartlomieju bartlomieju deleted the child_process_exec_sync branch August 11, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @kt3k