Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(_tools): fix type errors in _tools #3635

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 13, 2023

This PR fixes the below type errors in _tools. Currently scripts in _tools are not type-checked because they are not imported from any test cases. This PR also adds the type check task for them and run it in CI.

@kt3k kt3k changed the title chore(_tools): fix deprecation check tool chore(_tools): fix type errors in _tools Sep 13, 2023
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 62315dc into denoland:main Sep 13, 2023
9 checks passed
@kt3k kt3k deleted the fix-deprecation-check-tool branch September 13, 2023 13:11
JakeAve pushed a commit to JakeAve/deno_std that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants